dugenkui03 commented on PR #4113: URL: https://github.com/apache/rocketmq/pull/4113#issuecomment-1091087578
@lwclover #### Thanks for your reivew and suggestion `RouteInfoManager` log is modified for doing the same logic with others. The main propurse of this pr is that fixing the error rised from the incorrect position of `lockInterruptibly`, and not change the semantics of any method. #### 感谢建议和评论。 1. `RouteInfoManager` 中的日志打印已加上异常堆栈、**以和其他处理`InterruptedException`的逻辑对齐**。但其实这是没有必要的，因为加锁方法抛出的`InterruptedException`并不会打印任何有用信息、并且抛出异常的位置也是唯一的； 2. 其他建议均为同一类型：修改catch的异常类型、或者不catch某些异常。**这种修改会改变所在方法的语义**，比如之前方法的语义仅仅是 catch `InterruptedException`、修改会为catch所有异常、甚至包括 `RuntimeException`，这不是该PR的本意。该PR目的只有一个：修正 `lockInterruptibly` 使用位置导致问题导致的异常准确性和bug。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
