YxAc commented on code in PR #63:
URL: https://github.com/apache/rocketmq-mqtt/pull/63#discussion_r846792755
##########
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/mqtt/handler/MqttPubRecHandler.java:
##########
@@ -27,35 +26,26 @@
import org.apache.rocketmq.mqtt.common.hook.HookResult;
import org.apache.rocketmq.mqtt.cs.channel.ChannelInfo;
import org.apache.rocketmq.mqtt.cs.protocol.mqtt.MqttPacketHandler;
-import org.apache.rocketmq.mqtt.cs.session.infly.InFlyCache;
import org.apache.rocketmq.mqtt.cs.session.infly.RetryDriver;
-import org.apache.rocketmq.mqtt.cs.session.loop.SessionLoop;
import org.springframework.stereotype.Component;
import javax.annotation.Resource;
-
@Component
public class MqttPubRecHandler implements MqttPacketHandler<MqttMessage> {
+ private final MqttFixedHeader pubRelMqttFixedHeader = new
MqttFixedHeader(MqttMessageType.PUBREL, false,
+ MqttQoS.AT_LEAST_ONCE, false, 0);
Review Comment:
make fixHeader as private field to verify the correct 'qosLevel' in PUBREL
header for unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
