lwclover commented on code in PR #4157:
URL: https://github.com/apache/rocketmq/pull/4157#discussion_r849010724
##########
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java:
##########
@@ -496,11 +497,12 @@ public void operationComplete(ChannelFuture f) throws
Exception {
}
}
- private void requestFail(final int opaque) {
+ private void requestFail(final int opaque, Throwable cause) {
ResponseFuture responseFuture = responseTable.remove(opaque);
if (responseFuture != null) {
responseFuture.setSendRequestOK(false);
responseFuture.putResponse(null);
+ responseFuture.setCause(cause);
Review Comment:
I think we should add a nonnull judgment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
