cserwen commented on code in PR #4195:
URL: https://github.com/apache/rocketmq/pull/4195#discussion_r855788047
##########
common/src/main/java/org/apache/rocketmq/common/namesrv/NamesrvConfig.java:
##########
@@ -200,4 +221,68 @@ public boolean isEnableAllTopicList() {
public void setEnableAllTopicList(boolean enableAllTopicList) {
this.enableAllTopicList = enableAllTopicList;
}
+
+ public boolean isStartupController() {
+ return isStartupController;
+ }
+
+ public void setStartupController(boolean startupController) {
+ isStartupController = startupController;
+ }
+
+ public int getControllerThreadPoolNums() {
+ return controllerThreadPoolNums;
+ }
+
+ public void setControllerThreadPoolNums(int controllerThreadPoolNums) {
+ this.controllerThreadPoolNums = controllerThreadPoolNums;
+ }
+
+ public int getControllerRequestThreadPoolQueueCapacity() {
+ return controllerRequestThreadPoolQueueCapacity;
+ }
+
+ public void setControllerRequestThreadPoolQueueCapacity(int
controllerRequestThreadPoolQueueCapacity) {
+ this.controllerRequestThreadPoolQueueCapacity =
controllerRequestThreadPoolQueueCapacity;
+ }
+
+ public String getControllerDLegerGroup() {
+ return controllerDLegerGroup;
+ }
+
+ public void setControllerDLegerGroup(String controllerDLegerGroup) {
+ this.controllerDLegerGroup = controllerDLegerGroup;
+ }
+
+ public String getControllerDLegerPeers() {
+ return controllerDLegerPeers;
+ }
+
+ public void setControllerDLegerPeers(String controllerDLegerPeers) {
+ this.controllerDLegerPeers = controllerDLegerPeers;
+ }
+
+ public String getControllerDLegerSelfId() {
+ return controllerDLegerSelfId;
+ }
+
+ public void setControllerDLegerSelfId(String controllerDLegerSelfId) {
+ this.controllerDLegerSelfId = controllerDLegerSelfId;
+ }
+
+ public String getControllerStorePath() {
+ return controllerStorePath;
+ }
+
+ public void setControllerStorePath(String controllerStorePath) {
+ this.controllerStorePath = controllerStorePath;
+ }
+
+ public boolean isEnableElectUncleanMaster() {
+ return enableElectUncleanMaster;
+ }
+
+ public void setEnableElectUncleanMaster(boolean enableElectUncleanMaster) {
+ this.enableElectUncleanMaster = enableElectUncleanMaster;
+ }
Review Comment:
@dugenkui03
The setter method is required, otherwise the configuration will not take
effect.
https://github.com/apache/rocketmq/blob/bd3059e76a00b0496ba0e2e433f6266f2ceb5683/namesrv/src/main/java/org/apache/rocketmq/namesrv/NamesrvStartup.java#L93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
