RongtongJin commented on code in PR #4193:
URL: https://github.com/apache/rocketmq/pull/4193#discussion_r855796949
##########
broker/src/main/java/org/apache/rocketmq/broker/longpolling/LmqPullRequestHoldService.java:
##########
@@ -32,6 +32,9 @@ public LmqPullRequestHoldService(BrokerController
brokerController) {
@Override
public String getServiceName() {
+ if (brokerController != null &&
brokerController.getBrokerConfig().isInBrokerContainer()) {
+ return
this.brokerController.getBrokerIdentity().getLoggerIdentifier() +
LmqPullRequestHoldService.class.getSimpleName();
+ }
Review Comment:
Good catch!
##########
common/src/main/java/org/apache/rocketmq/common/UtilAll.java:
##########
@@ -220,7 +222,7 @@ public static boolean isPathExists(final String path) {
public static double getDiskPartitionSpaceUsedPercent(final String path) {
if (null == path || path.isEmpty()) {
- log.error("Error when measuring disk space usage, path is null or
empty, path : {}", path);
+ STORE_LOG.error("Error when measuring disk space usage, path is
null or empty, path : {}", path);
Review Comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
