hzh0425 commented on code in PR #4195: URL: https://github.com/apache/rocketmq/pull/4195#discussion_r857059556
########## namesrv/src/main/java/org/apache/rocketmq/namesrv/controller/manager/InSyncReplicasInfo.java: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.rocketmq.namesrv.controller.manager; + +import java.util.HashSet; +import java.util.Set; + +/** + * In sync replicas info, manages the master and syncStateSet of a broker. + */ +public class InSyncReplicasInfo { + private final String clusterName; + private final String brokerName; + + private Set<String/*Address*/> syncStateSet; + private int syncStateSetEpoch; + + private String masterAddress; + private int masterEpoch; + // Because when a Broker becomes a master, its id needs to be assigned a value of 0. + // We need to record it's originId so that when it becomes a follower again, we can find its original id. + private long masterOriginId; Review Comment: 讨论方案: 删除 masterOriginId. 不改变 brokerIdTable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
