dugenkui03 commented on PR #4094: URL: https://github.com/apache/rocketmq/pull/4094#issuecomment-1108845518
@RongtongJin 请帮忙重新review,PR有两点更改: 1. 在`DefaultLitePullConsumer#start()`加锁以避免多个线程并发访问该方法时造成的状态不一致,这是个低频方法所以不会对性能产生坏的影响; 2. 去掉`DefaultLitePullConsumerImpl.serviceState`,因为当前访问该状态的所有路径都加了对象锁、已经可以保证`serviceState`的可见性了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
