[GitHub] [rocketmq] cserwen commented on a diff in pull request #4224: [ISSUE #4223]Delete repeated calls in MQClientInstance.start

Fri, 29 Apr 2022 03:04:41 -0700 


cserwen commented on code in PR #4224:
URL: https://github.com/apache/rocketmq/pull/4224#discussion_r861665850


##########
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java:
##########
@@ -240,8 +240,6 @@ public void start() throws MQClientException {
                     this.pullMessageService.start();
                     // Start rebalance service
                     this.rebalanceService.start();
-                    // Start push service
-                    
this.defaultMQProducer.getDefaultMQProducerImpl().start(false);

Review Comment:
   It will be used to send retry messages if exception happens.
   
https://github.com/apache/rocketmq/blob/df3f8de4c03a282de052b130ae368ab00faca039/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java#L512
   
   
![image](https://user-images.githubusercontent.com/46882838/165924585-a98b5be4-c9a1-45f2-b7e7-9e5f1d0e41a6.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to