caigy commented on code in PR #4075:
URL: https://github.com/apache/rocketmq/pull/4075#discussion_r867294374
##########
store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:
##########
@@ -84,7 +84,7 @@
@ImportantField
private int fileReservedTime = 72;
// Flow control for ConsumeQueue
- private int putMsgIndexHightWater = 600000;
Review Comment:
@Hen1ng Fields in `MessageStoreConfig` may be set by reflection (you may
find such usage by `org.apache.rocketmq.common.MixAll#properties2Object`), once
you change the field names, users who have configured by the previous names
will be affected, the values they've changed in property file will be
'restored' to default values. So changing these fields require careful
consideration.
IMO, you'd better move this modification to another dedicated issue, and
change the field name in a compatible way also with clear documents addressing
to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
