hzh0425 commented on code in PR #4258:
URL: https://github.com/apache/rocketmq/pull/4258#discussion_r867461821
##########
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java:
##########
@@ -417,7 +417,7 @@ public void createTopic(String key, String newTopic, int
queueNum) throws MQClie
@Override
public void setUseTLS(boolean useTLS) {
super.setUseTLS(useTLS);
- if (traceDispatcher != null && traceDispatcher instanceof
AsyncTraceDispatcher) {
Review Comment:
I think 'traceDispatcher != null' is still needed
##########
client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java:
##########
@@ -896,7 +894,6 @@ public QueryResult queryMessage(String topic, String key,
int maxNum, long begin
public MessageExt viewMessage(String topic,
String msgId) throws RemotingException, MQBrokerException,
InterruptedException, MQClientException {
try {
- MessageId oldMsgId = MessageDecoder.decodeMessageId(msgId);
return this.viewMessage(msgId);
} catch (Exception e) {
}
Review Comment:
Oh, this method was 'Deprecated', just ignore it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
