YxAc commented on code in PR #93: URL: https://github.com/apache/rocketmq-mqtt/pull/93#discussion_r868051211
########## mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/session/infly/PushAction.java: ########## @@ -109,7 +108,6 @@ public void push(Message message, Subscription subscription, Session session, Qu Review Comment: For p2p message, no subscription is required, the 'message qos' is enough. IMO, this change is not necessary, FYI Maybe you should put 'min' operation out the judgment of p2p -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
