yuz10 commented on code in PR #4276:
URL: https://github.com/apache/rocketmq/pull/4276#discussion_r871092714
##########
acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java:
##########
@@ -113,11 +114,11 @@ public void load() {
return;
}
- Map<String, Map<String, PlainAccessResource>>
aclPlainAccessResourceMap = new HashMap<>();
- Map<String, String> accessKeyTable = new HashMap<>();
- List<RemoteAddressStrategy> globalWhiteRemoteAddressStrategy = new
ArrayList<>();
- Map<String, List<RemoteAddressStrategy>>
globalWhiteRemoteAddressStrategyMap = new HashMap<>();
- Map<String, DataVersion> dataVersionMap = new HashMap<>();
+ this.aclPlainAccessResourceMap = new HashMap<>();
+ this.accessKeyTable = new HashMap<>();
+ this.globalWhiteRemoteAddressStrategy = new ArrayList<>();
+ this.globalWhiteRemoteAddressStrategyMap = new HashMap<>();
+ this.dataVersionMap = new HashMap<>();
Review Comment:
Better update these fields after read from file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
