tsunghanjacktsai commented on code in PR #4301:
URL: https://github.com/apache/rocketmq/pull/4301#discussion_r872275599
##########
store/src/main/java/org/apache/rocketmq/store/MappedFile.java:
##########
@@ -371,18 +371,18 @@ private boolean isAbleToFlush(final int flushLeastPages) {
}
protected boolean isAbleToCommit(final int commitLeastPages) {
- int flush = this.committedPosition.get();
+ int commit = this.committedPosition.get();
Review Comment:
Hi, thx for your review. But I believe the name "commit" would be more
suitable for the usage of getting the previous committed position. Using
"flush" may be confused here since this.flushedPosition.get() in
isAbleToFlush() method is also named "flush" to represent getting the previous
flushed position.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
