hzh0425 commented on code in PR #4313:
URL: https://github.com/apache/rocketmq/pull/4313#discussion_r872908629
##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -1416,11 +1417,13 @@ public void request(Message msg, final RequestCallback
requestCallback, long tim
@Override
public void onSuccess(SendResult sendResult) {
requestResponseFuture.setSendRequestOk(true);
+ requestResponseFuture.executeRequestCallback();
}
@Override
public void onException(Throwable e) {
requestResponseFuture.setCause(e);
+ requestResponseFuture.executeRequestCallback();
requestFail(correlationId);
Review Comment:
' requestResponseFuture.executeRequestCallback' has been called in
'requestFail(correlationId)'
you don't need to call it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
