YxAc commented on code in PR #96:
URL: https://github.com/apache/rocketmq-mqtt/pull/96#discussion_r873166448
##########
mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/mq/MqFactory.java:
##########
@@ -58,55 +55,28 @@ public static synchronized DefaultMQPullConsumer
buildDefaultMQPullConsumer(Stri
}
public static DefaultMQProducer buildDefaultMQProducer(String group,
String nameSrv) {
- DefaultMQProducer defaultMQProducer = new DefaultMQProducer();
- defaultMQProducer.setNamesrvAddr(nameSrv);
- defaultMQProducer.setInstanceName(buildInstanceName());
- defaultMQProducer.setVipChannelEnabled(false);
- defaultMQProducer.setProducerGroup(group);
- return defaultMQProducer;
+ MqProducer mqProducer = new MqProducer(nameSrv);
+ mqProducer.setProducerGroup(group);
+ return mqProducer.getDefaultMQProducer();
}
public static DefaultMQPushConsumer buildDefaultMQPushConsumer(String
group, String nameSrv,
MessageListener messageListener, Properties properties) {
- DefaultMQPushConsumer defaultMQPushConsumer = new
DefaultMQPushConsumer();
- defaultMQPushConsumer.setNamesrvAddr(nameSrv);
- defaultMQPushConsumer.setConsumeMessageBatchMaxSize(1);
-
defaultMQPushConsumer.setPullBatchSize(Integer.parseInt(properties.getProperty("pullBatch",
"64")));
- if (properties.get(MqConsumer.THREAD_NUM_KEY) != null) {
- defaultMQPushConsumer.setConsumeThreadMin(Integer.valueOf((String)
properties.get("threadNum")));
- defaultMQPushConsumer.setConsumeThreadMax(Integer.valueOf((String)
properties.get("threadNum")));
- }
- defaultMQPushConsumer.setInstanceName(buildInstanceName());
- defaultMQPushConsumer.setVipChannelEnabled(false);
- defaultMQPushConsumer.setConsumerGroup(group);
- if (messageListener instanceof MessageListenerOrderly) {
-
defaultMQPushConsumer.registerMessageListener((MessageListenerOrderly)
messageListener);
- } else {
-
defaultMQPushConsumer.registerMessageListener((MessageListenerConcurrently)
messageListener);
- }
- return defaultMQPushConsumer;
+ MqConsumer mqConsumer = new MqConsumer(properties, nameSrv);
Review Comment:
reusing the same code block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
