caigy commented on code in PR #4296: URL: https://github.com/apache/rocketmq/pull/4296#discussion_r873183354
########## README.md: ########## @@ -35,20 +35,21 @@ It offers a variety of features: ## Apache RocketMQ Community * [RocketMQ Streams](https://github.com/apache/rocketmq-streams): A lightweight stream computing engine based on RocketMQ. -* [RocketMQ Flink](https://github.com/apache/rocketmq-flink): The RocketMQ connector of Flink that supports source and sink connector in data stream and Table. -* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp) -* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go) +* [RocketMQ Flink](https://github.com/apache/rocketmq-flink): The RocketMQ connector of Flink that supports source and sink connector in data stream and Table. +* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp): RocketMQ CPP Client. +* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go): RocketMQ Go Client. * [RocketMQ Client Python](https://github.com/apache/rocketmq-client-python) * [RocketMQ Client Nodejs](https://github.com/apache/rocketmq-client-nodejs) * [RocketMQ Spring](https://github.com/apache/rocketmq-spring) * [RocketMQ Exporter](https://github.com/apache/rocketmq-exporter) -* [RocketMQ Operator](https://github.com/apache/rocketmq-operator) -* [RocketMQ Docker](https://github.com/apache/rocketmq-docker) -* [RocketMQ Dashboard](https://github.com/apache/rocketmq-dashboard): Operation and maintenance console of RocketMQ -* [RocketMQ Connect](https://github.com/apache/rocketmq-connect): A tool for scalably and reliably streaming data between Apache RocketMQ and other systems -* [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt) -* [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals) +* [RocketMQ Operator](https://github.com/apache/rocketmq-operator): Provides a way to run an RocketMQ cluster on Kubernetes. Review Comment: 1. It seems `Providing` should be used instead of `Provides`. 2. `an Apache RocketMQ cluster` is more appropriate. ########## README.md: ########## @@ -35,20 +35,21 @@ It offers a variety of features: ## Apache RocketMQ Community * [RocketMQ Streams](https://github.com/apache/rocketmq-streams): A lightweight stream computing engine based on RocketMQ. -* [RocketMQ Flink](https://github.com/apache/rocketmq-flink): The RocketMQ connector of Flink that supports source and sink connector in data stream and Table. -* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp) -* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go) +* [RocketMQ Flink](https://github.com/apache/rocketmq-flink): The RocketMQ connector of Flink that supports source and sink connector in data stream and Table. +* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp): RocketMQ CPP Client. +* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go): RocketMQ Go Client. Review Comment: Seems not more descriptive than the original ones. Maybe you can refer to corresponding projects for more specific description. ########## README.md: ########## @@ -35,20 +35,21 @@ It offers a variety of features: ## Apache RocketMQ Community * [RocketMQ Streams](https://github.com/apache/rocketmq-streams): A lightweight stream computing engine based on RocketMQ. -* [RocketMQ Flink](https://github.com/apache/rocketmq-flink): The RocketMQ connector of Flink that supports source and sink connector in data stream and Table. -* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp) -* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go) +* [RocketMQ Flink](https://github.com/apache/rocketmq-flink): The RocketMQ connector of Flink that supports source and sink connector in data stream and Table. +* [RocketMQ Client CPP](https://github.com/apache/rocketmq-client-cpp): RocketMQ CPP Client. +* [RocketMQ Client Go](https://github.com/apache/rocketmq-client-go): RocketMQ Go Client. * [RocketMQ Client Python](https://github.com/apache/rocketmq-client-python) * [RocketMQ Client Nodejs](https://github.com/apache/rocketmq-client-nodejs) * [RocketMQ Spring](https://github.com/apache/rocketmq-spring) * [RocketMQ Exporter](https://github.com/apache/rocketmq-exporter) -* [RocketMQ Operator](https://github.com/apache/rocketmq-operator) -* [RocketMQ Docker](https://github.com/apache/rocketmq-docker) -* [RocketMQ Dashboard](https://github.com/apache/rocketmq-dashboard): Operation and maintenance console of RocketMQ -* [RocketMQ Connect](https://github.com/apache/rocketmq-connect): A tool for scalably and reliably streaming data between Apache RocketMQ and other systems -* [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt) -* [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals) +* [RocketMQ Operator](https://github.com/apache/rocketmq-operator): Provides a way to run an RocketMQ cluster on Kubernetes. +* [RocketMQ Docker](https://github.com/apache/rocketmq-docker): The Git repo of the Docker Image for Apache RocketMQ. +* [RocketMQ Dashboard](https://github.com/apache/rocketmq-dashboard): Operation and maintenance console of RocketMQ. +* [RocketMQ Connect](https://github.com/apache/rocketmq-connect): A tool for scalably and reliably streaming data between Apache RocketMQ and other systems. +* [RocketMQ MQTT](https://github.com/apache/rocketmq-mqtt): A new MQTT protocol architecture model, based on which RocketMQ can better support messages from terminals such as IoT devices and Mobile APP. +* [RocketMQ Incubating Community Projects](https://github.com/apache/rocketmq-externals): Apache rocketmq is incubating the ecological project warehouse, including Spark, ES, Beats and other connectors. Review Comment: 1. Please use `Apache RocketMQ` for consistency. 2. Could you please explain the meaning of 'warehouse' here? It is a bit confusing. 3. rocketmq-externals is a repository for incubator projects related to Apache RocketMQ, not limited to connectors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
