lwclover commented on code in PR #4268:
URL: https://github.com/apache/rocketmq/pull/4268#discussion_r873432857
##########
namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java:
##########
@@ -88,6 +88,36 @@ public void deleteTopic(final String topic) {
}
}
+ public void deleteTopic(final String topic, final String clusterName) {
+ try {
+ try {
+ this.lock.writeLock().lockInterruptibly();
+ Set<String> brokerNames =
this.clusterAddrTable.get(clusterName);
+ if (brokerNames != null
+ && !brokerNames.isEmpty()) {
+ Map<String, QueueData> queueDataMap =
this.topicQueueTable.get(topic);
+ for (String brokerName : brokerNames) {
+ final QueueData removedQD =
queueDataMap.remove(brokerName);
+ if (removedQD != null) {
+ log.info("deleteTopic, remove one broker's topic
{} {} {}", brokerName, topic,
+ removedQD);
+ }
+
+ if (queueDataMap.isEmpty()) {
Review Comment:
My personal recommendation is to put it outside of the for loop, so it's a
little more logical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
