Oliverwqcwrw commented on code in PR #4350:
URL: https://github.com/apache/rocketmq/pull/4350#discussion_r878792022
##########
client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java:
##########
@@ -76,7 +76,9 @@ public String pickOneAtLeast() {
if (half <= 0) {
return tmpList.get(0).getName();
} else {
- final int i = this.whichItemWorst.incrementAndGet() % half;
+ int i = this.whichItemWorst.incrementAndGet() % half;
+ if (i < 0)
Review Comment:
Agree with, I think it would be better to add the comment above the `if(i <
0)`,WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
