lizhanhui commented on code in PR #39:
URL: https://github.com/apache/rocketmq-apis/pull/39#discussion_r884526657
##########
apache/rocketmq/v2/service.proto:
##########
@@ -248,6 +248,8 @@ message Settings {
optional Endpoints access_point = 2;
+ optional string deployment_name = 3;
Review Comment:
1. Is there a way to tag this field is of [out] type, up to servers to fill?
2. rename deployment_name --> deployment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
