SteNicholas commented on code in PR #28:
URL: https://github.com/apache/rocketmq-flink/pull/28#discussion_r885153668
##########
src/main/java/org/apache/rocketmq/flink/source/reader/RocketMQPartitionSplitReader.java:
##########
@@ -148,30 +153,44 @@ public RecordsWithSplitIds<Tuple3<T, Long, Long>> fetch()
throws IOException {
if (wakeup) {
LOG.info(
String.format(
- "Wake up pulling messages of topic[%s]
broker[%s] queue[%d] tag[%s] from offset[%d].",
+ "Wake up pulling messages of topic[%s]
broker[%s] queue[%d] tag[%s] sql[%s] from offset[%d].",
messageQueue.getTopic(),
messageQueue.getBrokerName(),
messageQueue.getQueueId(),
tag,
+ sql,
messageOffset));
wakeup = false;
recordsBySplits.prepareForRead();
return recordsBySplits;
}
- pullResult =
- consumer.pull(
- messageQueue, tag, messageOffset,
MAX_MESSAGE_NUMBER_PER_BLOCK);
+ if (StringUtils.isNotEmpty(tag)) {
+ pullResult =
+ consumer.pull(
+ messageQueue,
+ tag,
+ messageOffset,
+ MAX_MESSAGE_NUMBER_PER_BLOCK);
+ } else {
Review Comment:
Should this check whether `sql` is empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
