zhouxinyu commented on code in PR #4446:
URL: https://github.com/apache/rocketmq/pull/4446#discussion_r894430839
##########
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java:
##########
@@ -166,22 +178,55 @@ public void processMessageReceived(ChannelHandlerContext
ctx, RemotingCommand ms
}
}
+ protected Decision preHandle(final HandlerContext context, final
RemotingCommand request,
+ final CompletableFuture<RemotingCommand>
responseFuture) {
+ Decision decision = Decision.CONTINUE;
+ for (Handler handler : handlers) {
+ try {
+ decision = handler.preHandle(context, request, responseFuture);
+ } catch (Throwable ignore) {
Review Comment:
Exception means CONTINUE, is that reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
