ShannonDing commented on code in PR #4453:
URL: https://github.com/apache/rocketmq/pull/4453#discussion_r895271605
##########
client/src/main/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStore.java:
##########
@@ -82,9 +82,8 @@ public long readOffset(final MessageQueue mq, final
ReadOffsetType type) {
AtomicLong offset = this.offsetTable.get(mq);
if (offset != null) {
return offset.get();
- } else if (ReadOffsetType.READ_FROM_MEMORY == type) {
- return -1;
Review Comment:
offset will be got from remote broker if it was got failed in local offset
table in MEMORY_FIRST_THEN_STORE model.
Just return -1 in READ_FROM_MEMORY model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
