hzh0425 commented on code in PR #4467:
URL: https://github.com/apache/rocketmq/pull/4467#discussion_r898615369
##########
store/src/test/java/org/apache/rocketmq/store/ha/HAServerTest.java:
##########
@@ -193,10 +193,10 @@ public void putRequest_SingleAck() throws IOException,
ExecutionException, Inter
@Test
public void putRequest_MultipleAckAndRequests() throws IOException,
ExecutionException, InterruptedException {
- CommitLog.GroupCommitRequest oneAck = new
CommitLog.GroupCommitRequest(124, 4000,1);
+ CommitLog.GroupCommitRequest oneAck = new
CommitLog.GroupCommitRequest(124, 4000,2);
this.haService.putRequest(oneAck);
Review Comment:
It's better format to (124, 4000, 2)
##########
store/src/test/java/org/apache/rocketmq/store/ha/HAServerTest.java:
##########
@@ -213,7 +213,7 @@ public void putRequest_MultipleAckAndRequests() throws
IOException, ExecutionExc
doReturn(128L).when(messageStore).getMasterFlushedOffset();
setUpOneHAClient(messageStore);
- twoAck = new CommitLog.GroupCommitRequest(124, 4000,2);
+ twoAck = new CommitLog.GroupCommitRequest(124, 4000,3);
this.haService.putRequest(twoAck);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
