azhsmesos commented on code in PR #4477:
URL: https://github.com/apache/rocketmq/pull/4477#discussion_r901085961
##########
broker/src/main/java/org/apache/rocketmq/broker/transaction/queue/TransactionalMessageServiceImpl.java:
##########
@@ -354,7 +358,13 @@ private PutMessageResult
putBackToHalfQueueReturnResult(MessageExt messageExt) {
PutMessageResult putMessageResult = null;
try {
MessageExtBrokerInner msgInner =
transactionalMessageBridge.renewHalfMessageInner(messageExt);
- putMessageResult =
transactionalMessageBridge.putMessageReturnResult(msgInner);
+ if
(this.transactionalMessageBridge.getBrokerController().isSpecialServiceRunning()
+ && BrokerRole.SLAVE ==
this.transactionalMessageBridge.getBrokerController().getMessageStoreConfig()
+ .getBrokerRole()) {
+ putMessageResult =
transactionalMessageBridge.getBrokerController().getEscapeBridge().putMessage(msgInner);
+ } else {
+ putMessageResult =
transactionalMessageBridge.putMessageReturnResult(msgInner);
+ }
Review Comment:
The transactionmessageserviceimpl#putbacktohalfqueuereturnresult() method
needs to rewrite the half message. Here,I think we have to rewrite the topic. I
understand that this step should also be carried out by escaping to other
masters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
