lwclover commented on PR #4383: URL: https://github.com/apache/rocketmq/pull/4383#issuecomment-1161633919
> @lwclover I have read all the code. This solution is simple and useful in some cases. > > And the same time, there are two potential problems. > > Firstly, in the public cloud or hybrid cloud, with SLB/PrivateLink, the network may be complicated, and we may not able to identify the client/broker by their remote address. So we may need a more common way to identify the client/broker. For example, we could abstract a config named "site", and the client/broker inject the "site" info to the extFields of RemotingCommand. > > Secondly, we may need a way to solve the conflict between consumers of the same group in different networks. For example, some consumers on site A, some consumers on site global. @dongeforever Thank you for reviewing my code. For your first suggestion, My goal is to be transparent to the client，if I abstract a config named "site", client/broker need config it. For your sencod suggestion,I agree with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
