ifplusor commented on code in PR #419:
URL:
https://github.com/apache/rocketmq-client-cpp/pull/419#discussion_r906770176
##########
src/transport/TcpTransport.cpp:
##########
@@ -207,7 +207,7 @@ void TcpTransport::eventCallback(BufferEvent* event, short
what, TcpTransport* t
// disable Nagle
int val = 1;
- setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, (void*)&val, sizeof(val));
+ setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, static_cast<const char
*>((void*)&val), sizeof(val));
Review Comment:
Why not below?
```c++
setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, static_cast<const char
*>(&val), sizeof(val));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
