lizhiboo commented on issue #180:
URL: 
https://github.com/apache/rocketmq-connect/issues/180#issuecomment-1166723804

   > Currently, WorkerSourceTask does not have the logic of commit call, and it 
will only automatically commit the offset when the sending is successful. In 
order to support the ability of SourceTask to maintain the offset by itself, 
the logic of the new commit can be optimized. The most important thing for 
success and failure is the impact on the offset.
   
   Yes, the logic of the new commit will be optimized. IMO, open the conduction 
of sending failure to users will be better, like the interface 
dismissFailedMsgs in the above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to