liuzongliang0202 commented on code in PR #4518:
URL: https://github.com/apache/rocketmq/pull/4518#discussion_r907976406
##########
store/src/main/java/org/apache/rocketmq/store/index/IndexService.java:
##########
@@ -366,7 +366,18 @@ public void start() {
}
+ // fix issue 4463
public void shutdown() {
-
+ if (!indexFileList.isEmpty()) {
+ final IndexFile indexFile = indexFileList.get(indexFileList.size()
- 1);
+ long indexMsgTimestamp = 0;
+ if (indexFile.isWriteFull()) {
+ indexMsgTimestamp = indexFile.getEndTimestamp();
+ }
+ indexFile.flush();
+ if (indexMsgTimestamp > 0) {
+
this.defaultMessageStore.getStoreCheckpoint().setIndexMsgTimestamp(indexMsgTimestamp);
+ }
Review Comment:
because class DefaultMessageStore will call storeCheckpoint.flush() after
indexService.shutdown()
this.storeStatsService.shutdown();
this.indexService.shutdown();
this.commitLog.shutdown();
this.reputMessageService.shutdown();
this.flushConsumeQueueService.shutdown();
this.allocateMappedFileService.shutdown();
this.storeCheckpoint.flush();
this.storeCheckpoint.shutdown();
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
