[GitHub] [rocketmq] PansonPanson opened a new pull request, #4532: [ISSUE #4513] elegant equals using apache-commons

[GitBox]

PansonPanson opened a new pull request, #4532:
URL: https://github.com/apache/rocketmq/pull/4532

   I'm reading the sourcecode of store module and there are some cpde snippets  
in class org.apache.rocketmq.store.DefaultMessageStore that I think need to be 
fixed.
   
   - **code snippet 1**: redundant code  and  unreachable statement (`match`   
is always true)
   
   <img width="1177" alt="Screen Shot 2022-06-29 at 21 34 38" 
src="https://user-images.githubusercontent.com/16064908/176451335-51e16363-081c-4077-9c1b-e5aa39c8287c.png";>
   
   - code snippet 2 : replacing with `enhanced for` to Improve code readability
   <img width="1101" alt="image" 
src="https://user-images.githubusercontent.com/16064908/176458447-64fb2c6c-7570-4513-ade1-0c6174865704.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org