Oliverwqcwrw commented on code in PR #4523:
URL: https://github.com/apache/rocketmq/pull/4523#discussion_r911540607
##########
namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java:
##########
@@ -240,6 +240,13 @@ public RemotingCommand
registerBrokerWithFilterServer(ChannelHandlerContext ctx,
registerBrokerBody.getFilterServerList(),
ctx.channel());
+ if (result == null) {
Review Comment:
The `result` seems can not null, it is initialized in first line, please
correct me if I understand error
> public RegisterBrokerResult registerBroker(
final String clusterName,
final String brokerAddr,
final String brokerName,
final long brokerId,
final String haServerAddr,
final TopicConfigSerializeWrapper topicConfigWrapper,
final List<String> filterServerList,
final Channel channel) {
RegisterBrokerResult result = new RegisterBrokerResult();
try {
try {
this.lock.writeLock().lockInterruptibly();
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
