Oliverwqcwrw commented on code in PR #4498:
URL: https://github.com/apache/rocketmq/pull/4498#discussion_r913325151
##########
client/src/main/java/org/apache/rocketmq/client/Validators.java:
##########
@@ -107,4 +110,19 @@ public static void isNotAllowedSendTopic(String topic)
throws MQClientException
}
}
+ public static void checkTopicConfig(final TopicConfig topicConfig) throws
MQClientException {
+ if (!PermName.isValid(topicConfig.getPerm())) {
+ throw new MQClientException(ResponseCode.NO_PERMISSION,
+ String.format("brokerPermission value: %s is invalid.",
topicConfig.getPerm()));
Review Comment:
`brokerPermission value` should be `topicPermisson value`, and is more
accurate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
