shengminw commented on code in PR #4553:
URL: https://github.com/apache/rocketmq/pull/4553#discussion_r914368950
##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -492,28 +492,33 @@ public void send(final Message msg, final SendCallback
sendCallback, final long
throws MQClientException, RemotingException, InterruptedException {
final long beginStartTime = System.currentTimeMillis();
ExecutorService executor = this.getAsyncSenderExecutor();
- try {
- executor.submit(new Runnable() {
- @Override
- public void run() {
- long costTime = System.currentTimeMillis() -
beginStartTime;
- if (timeout > costTime) {
- try {
- sendDefaultImpl(msg, CommunicationMode.ASYNC,
sendCallback, timeout - costTime);
- } catch (Exception e) {
- sendCallback.onException(e);
- }
- } else {
- sendCallback.onException(
- new RemotingTooMuchRequestException("DEFAULT ASYNC
send call timeout"));
+ Runnable runnable = new Runnable() {
+ @Override
+ public void run() {
+ long costTime = System.currentTimeMillis() - beginStartTime;
+ if (timeout > costTime) {
+ try {
+ sendDefaultImpl(msg, CommunicationMode.ASYNC,
sendCallback, timeout - costTime);
+ } catch (Exception e) {
+ sendCallback.onException(e);
}
+ } else {
+ sendCallback.onException(
+ new RemotingTooMuchRequestException("DEFAULT ASYNC
send call timeout"));
}
+ }
- });
- } catch (RejectedExecutionException e) {
- throw new MQClientException("executor rejected ", e);
- }
+ };
+ if (this.defaultMQProducer.isEnableBackpressureForAsyncMode() &&
this.asyncSenderExecutor == null) {
+ runnable.run();
Review Comment:
I think if users set custom ThreadPoolExecutors, they may need the
ThreadPoolExecutors, not just run in the thread.
But keeping semantic consitacy is also important, so I think I can fix it ,
through setting `asyncSenderExecutor` false when user set custom
ThreadPoolExecutor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
