lizhiboo commented on code in PR #4562:
URL: https://github.com/apache/rocketmq/pull/4562#discussion_r916384377
##########
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java:
##########
@@ -603,11 +607,14 @@ private void uploadFilterClassSource() {
}
}
- public boolean updateTopicRouteInfoFromNameServer(final String topic,
boolean isDefault,
+ public boolean updateTopicRouteInfoFromNameServer(final String topic,
boolean isDefault, boolean isEmpty2FetchFromNameServer,
Review Comment:
IMO, in this merge request, parameter isEmpty2FetchFromNameServer can be
replaced by force2FetchFromNameServer that means update topic route info from
namesrv directly whether client already have topic info or not. If still using
parameter isEmpty2FetchFromNameServer, its value will be reversed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
