RongtongJin opened a new pull request, #4578:
URL: https://github.com/apache/rocketmq/pull/4578

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   Recently we released 4.9.4 LTS version. The LTS version is the long-term 
support version. Subsequent bug fixes will be backported to this version from 
the trunk in a timely manner. We have created a 4.9.x branch, which is used for 
the long-term repair of bugs in RocketMQ 4.9.x.
   
   This pull request will now merge the code in RocketMQ 5.0 into the develop 
branch. All the new features of RocketMQ 5.x will be in the develop branch 
later. Let’s look forward to the first version of RocketMQ 5.0.
   
   ## Brief changelog
   
   All the changes in 
[5.0.0-beta](https://github.com/apache/rocketmq/tree/5.0.0-beta)  branch
   
   ## Verifying this change
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to