Oliverwqcwrw commented on issue #4591:
URL: https://github.com/apache/rocketmq/issues/4591#issuecomment-1183840962

   1、I think 
`org.apache.rocketmq.logging.inner.LoggingBuilder.FileAppender#setFile(java.lang.String)`
 also need `synchronized `
   
   2、You are right, there do not exist concurrency issue, However, if someone 
calls this method in the future, synchronization control will be added, I think 
it's ok to add it in advance
   
   Thanks for your advice 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to