RongtongJin commented on code in PR #4610:
URL: https://github.com/apache/rocketmq/pull/4610#discussion_r921991173
##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -1141,7 +1141,7 @@ private SendResult sendSelectImpl(
long costTime = System.currentTimeMillis() - beginStartTime;
if (timeout < costTime) {
- throw new RemotingTooMuchRequestException("sendSelectImpl call
timeout");
+ throw new RemotingTimeoutException("sendSelectImpl call
timeout");
Review Comment:
I think neither of the two exceptions is appropriate here. But
RemotingTimeoutException is more suitable than RemotingTooMuchRequestException,
so I agree with this replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
