tsunghanjacktsai commented on code in PR #4615:
URL: https://github.com/apache/rocketmq/pull/4615#discussion_r922644585
##########
client/src/main/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStore.java:
##########
@@ -213,6 +213,7 @@ public void updateConsumeOffsetToBroker(MessageQueue mq,
long offset, boolean is
requestHeader.setConsumerGroup(this.groupName);
requestHeader.setQueueId(mq.getQueueId());
requestHeader.setCommitOffset(offset);
+ requestHeader.setBname(mq.getBrokerName());
Review Comment:
Hi @drpmma ,
Why not just simply name it "brokerName" instead of "bname" to make it more
straightforward? I felt confused for a second after I saw your description haha.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
