PansonPanson opened a new issue, #4634:
URL: https://github.com/apache/rocketmq/issues/4634

   I have read over the sourcecode of namesrv module,there are some code 
snippets need to be fixed.
   
   1. 
   
![image](https://user-images.githubusercontent.com/16064908/179765314-44a90645-998a-4156-b583-2f48706d0c74.png)
   
   2. grammatical error
   
![image](https://user-images.githubusercontent.com/16064908/179766101-07ec4122-552d-4d4e-9b7c-bc8dda0392af.png)
   
   3. 中文语句不通顺,中、英文逗号混用
   
![image](https://user-images.githubusercontent.com/16064908/179766318-dbdbb264-d904-4ca1-ac56-44a3e41e0d06.png)
   
   4. redundant parameter
   
![image](https://user-images.githubusercontent.com/16064908/179766616-4d2d42af-59ad-4b2a-89b8-3a582b7d3d57.png)
   
   5. apache commons
   
![image](https://user-images.githubusercontent.com/16064908/179766764-d40b97ee-4404-42ba-a636-02113b446661.png)
   
   6. for each
   
![image](https://user-images.githubusercontent.com/16064908/179767033-5005e79b-7f46-4f81-bf4c-a2eb0d0f850a.png)
   
   7. redundant code 
   
![image](https://user-images.githubusercontent.com/16064908/179767259-ecabf3e1-953e-4038-aecb-c55dc5820ebb.png)
   
   8. try with resources
   
![image](https://user-images.githubusercontent.com/16064908/179767499-83d724d1-e709-4448-b89f-3f30052e29b9.png)
   
   9. replace with append
   
![image](https://user-images.githubusercontent.com/16064908/179767698-f8dd99d9-2a96-4cf3-9e46-8d8db0441172.png)
   
   10.
   
![image](https://user-images.githubusercontent.com/16064908/179767779-9812f88c-c010-44f7-b668-308f7d8dea51.png)
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to