[GitHub] [rocketmq-schema-registry] MatrixHB commented on a diff in pull request #4: optimize Schema Rest API and the cache refresh mechanism

Wed, 20 Jul 2022 01:58:35 -0700 


MatrixHB commented on code in PR #4:
URL: 
https://github.com/apache/rocketmq-schema-registry/pull/4#discussion_r925355256


##########
core/src/main/java/org/apache/rocketmq/schema/registry/core/api/v1/SchemaController.java:
##########
@@ -60,13 +63,15 @@ public SchemaController(
         final RequestProcessor requestProcessor,
         final SchemaService<SchemaDto> schemaService
     ) {
+        this.cluster = QualifiedName.DEFAULT_CLUSTER;
+        this.tenant = QualifiedName.DEFAULT_TENANT;
         this.requestProcessor = requestProcessor;
         this.schemaService = schemaService;
     }
 
     @RequestMapping(
         method = RequestMethod.POST,
-        path = 
"/cluster/{cluster-name}/subject/{subject-name}/schema/{schema-name}",

Review Comment:
   The rest apis are as follows now after I take your suggestion.
   
![image](https://user-images.githubusercontent.com/23614576/179941609-d7087cbb-49f1-4b7b-870c-81e3ba1a576f.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to