RongtongJin commented on code in PR #4642:
URL: https://github.com/apache/rocketmq/pull/4642#discussion_r925519051
##########
common/src/main/java/org/apache/rocketmq/common/MixAll.java:
##########
@@ -72,6 +72,7 @@ public class MixAll {
public static final String ONS_HTTP_PROXY_GROUP = "CID_ONS-HTTP-PROXY";
public static final String CID_ONSAPI_PERMISSION_GROUP =
"CID_ONSAPI_PERMISSION";
public static final String CID_ONSAPI_OWNER_GROUP = "CID_ONSAPI_OWNER";
+ public static final String SYSTEM_TOPIC_PREFIX = "RMQ_SYS_";
Review Comment:
There is an same constant in the TopicValidator class
(org.apache.rocketmq.common.topic.TopicValidator#SYSTEM_TOPIC_PREFIX). I don't
think it's necessary to re create one here
##########
store/pom.xml:
##########
@@ -67,5 +67,14 @@
<artifactId>logback-classic</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.conversantmedia</groupId>
+ <artifactId>disruptor</artifactId>
+ <version>1.2.10</version>
Review Comment:
It would be better if we can put the version to the parent pom file.
##########
example/pom.xml:
##########
@@ -64,5 +64,10 @@
<groupId>io.jaegertracing</groupId>
<artifactId>jaeger-client</artifactId>
</dependency>
+ <dependency>
+ <groupId>commons-cli</groupId>
+ <artifactId>commons-cli</artifactId>
+ <version>1.4</version>
Review Comment:
Delete this line, we can use the parent pom file dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
