pherzheyu commented on code in PR #71:
URL: https://github.com/apache/rocketmq-clients/pull/71#discussion_r927217458
##########
golang/producer.go:
##########
@@ -22,34 +22,51 @@ import (
"errors"
"fmt"
"log"
+ "math"
"sync"
"time"
v2 "github.com/apache/rocketmq-clients/golang/protocol/v2"
"github.com/apache/rocketmq-clients/golang/utils"
+ "github.com/valyala/fastrand"
+ "google.golang.org/protobuf/types/known/durationpb"
)
type Producer interface {
Send(context.Context, *Message) ([]*SendReceipt, error)
+ SendWithTransaction(context.Context, *Message, Transaction)
([]*SendReceipt, error)
SendAsync(context.Context, *Message, func(context.Context,
[]*SendReceipt, error))
+ BeginTransaction() Transaction
GracefulStop() error
+ isClient
Review Comment:
非常不建议interface中定义非导出方法
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
