caigy commented on code in PR #106:
URL: https://github.com/apache/rocketmq-operator/pull/106#discussion_r931907001
##########
pkg/apis/rocketmq/v1alpha1/nameservice_types.go:
##########
@@ -63,6 +63,8 @@ type NameServiceSpec struct {
NodeSelector map[string]string `json:"nodeSelector,omitempty"`
// PriorityClassName indicates the pod's priority
PriorityClassName string `json:"priorityClassName,omitempty"`
+ // ServiceAccountName
+ ServiceAccountName string `json:"ServiceAccountName,omitempty"`
Review Comment:
Pls use little camel cased `serviceAccountName` in json tag for convention.
##########
pkg/apis/rocketmq/v1alpha1/broker_types.go:
##########
@@ -70,6 +70,8 @@ type BrokerSpec struct {
NodeSelector map[string]string `json:"nodeSelector,omitempty"`
// PriorityClassName indicates the pod's priority
PriorityClassName string `json:"priorityClassName,omitempty"`
+ // ServiceAccountName
+ ServiceAccountName string `json:"ServiceAccountName,omitempty"`
Review Comment:
Pls use little camel cased `serviceAccountName` in json tag for convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
