[GitHub] [rocketmq] mxsm opened a new issue, #4721: [Optimize]NamesrvStartup has some code snippet It will never be executed

Thu, 28 Jul 2022 21:30:34 -0700 


mxsm opened a new issue, #4721:
URL: https://github.com/apache/rocketmq/issues/4721

   as following:
   
![image](https://user-images.githubusercontent.com/15797831/181682560-89db5785-bf0c-4816-b2c5-0dbabfe87854.png)
   NamesrvController.initialize never return false. this method return true or 
throw exception. so
   ```java
    if (!initResult) {
         controller.shutdown();
         System.exit(-3);
   }
   ```
   this code snippet can be removed.  
   ControllerStartup class has the same problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to