keranbingaa commented on code in PR #46:
URL: https://github.com/apache/rocketmq-flink/pull/46#discussion_r934626417
##########
src/main/java/org/apache/rocketmq/flink/legacy/RocketMQSourceFunction.java:
##########
@@ -241,91 +243,58 @@ public void run(SourceContext context) throws Exception {
() -> {
while (runningChecker.isRunning()) {
try {
- long offset =
getMessageQueueOffset(mq);
-
- PullResult pullResult = null;
+ getMessageQueueOffset(mq);
if (StringUtils.isEmpty(sql)) {
- pullResult =
-
consumer.pullBlockIfNotFound(
- mq, tag,
offset, pullBatchSize);
+ consumer.subscribe(topic,
tag);
Review Comment:
this can be put out of the while loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
