humkum commented on PR #25: URL: https://github.com/apache/rocketmq-schema-registry/pull/25#issuecomment-1203444750
> > > What is the relation between SpecificAvroSerde, GernericAvroSerde and AvroSerde？Up-down dependency, or parallel ? > > > If SpecificAvroSerde and GernericAvroSerde are exposed to users and they are dependent on AvroSerde, I think AvroSerde should be moved to common module, to avoid user confusion. If they are parallel, it is better to merge the Serde package and the Serializer package. Or I will feel a bit confused about which to choose. > > > @humkum @ferrirW > > > > > > I can't agree more with you, their relationship is an Up-down dependency, and I agree to move AvroSerde to common package > > I‘m sorry. I try to move to common module but it's more unreasonable because AvroSerde is dependent on SchemaRegistryClient, so let's just keep this way. I guess you have learned kafka-schema-registry, so I agree with your current design. > > _Is it better to make a "avro" package under the "serde" path, leave expansion room for JSON serde and Protobuf serde ?_ BTW, you can take this into consideration. Okay , it's a future plan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
