mxsm commented on code in PR #4768:
URL: https://github.com/apache/rocketmq/pull/4768#discussion_r936256343
##########
controller/src/main/java/org/apache/rocketmq/controller/ControllerManager.java:
##########
@@ -91,6 +91,12 @@ protected <T> RunnableFuture<T> newTaskFor(final Runnable
runnable, final T valu
}
};
this.heartbeatManager = new
DefaultBrokerHeartbeatManager(this.controllerConfig);
+ if
(StringUtils.isEmpty(this.controllerConfig.getControllerDLegerPeers())) {
+ throw new IllegalArgumentException("Attribute value
controllerDLegerPeers of ControllerConfig is null");
+ }
+
if(StringUtils.isEmpty(this.controllerConfig.getControllerDLegerSelfId())){
+ throw new IllegalArgumentException("Attribute value
controllerDLegerSelfId of ControllerConfig is null");
Review Comment:
> 'is null or empty' may be more accurate.
OK I will modify it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
