ShannonDing commented on code in PR #4796:
URL: https://github.com/apache/rocketmq/pull/4796#discussion_r939802600
##########
controller/src/main/java/org/apache/rocketmq/controller/impl/manager/ReplicasInfoManager.java:
##########
@@ -211,8 +211,10 @@ private boolean tryElectMaster(final
ControllerResult<ElectMasterResponseHeader>
response.setNewMasterAddress(candidate);
response.setMasterEpoch(masterEpoch + 1);
response.setSyncStateSetEpoch(syncStateSetEpoch);
-
response.setBrokerMemberGroup(buildBrokerMemberGroup(brokerName));
-
+ BrokerMemberGroup brokerMemberGroup =
buildBrokerMemberGroup(brokerName);
+ if (null != brokerMemberGroup) {
Review Comment:
what's the default value if buildBrokerMemberGroup is null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
