TheR1sing3un commented on code in PR #4809:
URL: https://github.com/apache/rocketmq/pull/4809#discussion_r944712670
##########
controller/src/main/java/org/apache/rocketmq/controller/impl/DLedgerController.java:
##########
@@ -77,20 +81,25 @@ public class DLedgerController implements Controller {
private final DLedgerControllerStateMachine statemachine;
// Usr for checking whether the broker is alive
private BiPredicate<String, String> brokerAlivePredicate;
+
+ private BiFunction<String, String, BrokerLiveInfo> additionalInfoGetter;
+
+
private AtomicBoolean isScheduling = new AtomicBoolean(false);
public DLedgerController(final ControllerConfig config, final
BiPredicate<String, String> brokerAlivePredicate) {
- this(config, brokerAlivePredicate, null, null, null);
+ this(config, brokerAlivePredicate, null, null, null, null);
}
public DLedgerController(final ControllerConfig controllerConfig,
final BiPredicate<String, String> brokerAlivePredicate, final
NettyServerConfig nettyServerConfig,
- final NettyClientConfig nettyClientConfig, final ChannelEventListener
channelEventListener) {
+ final NettyClientConfig nettyClientConfig, final ChannelEventListener
channelEventListener,
+ BiFunction<String, String, BrokerLiveInfo>
additionalInfoGetter) {
Review Comment:
Right! But brokerAlivePredicate still needs to be used! So I just replace
the addtionalInfoGetter with electPolicy there. Thanks for your suggestion~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
