mxsm opened a new issue, #4847:
URL: https://github.com/apache/rocketmq/issues/4847
DefaultBrokerHeartbeatManager#onBrokerHeartbeat
```java
@Override
public void onBrokerHeartbeat(String clusterName, String brokerAddr,
Integer epoch, Long maxOffset, Long confirmOffset) {
BrokerAddrInfo addrInfo = new BrokerAddrInfo(clusterName,
brokerAddr);
BrokerLiveInfo prev = this.brokerLiveTable.get(addrInfo);
int realEpoch = epoch == null ? -1 : epoch;
long realMaxOffset = maxOffset == null ? -1 : maxOffset;
long realConfirmOffset = confirmOffset == null ? -1 : confirmOffset;
if (prev != null) {
prev.setLastUpdateTimestamp(System.currentTimeMillis());
if (realEpoch > prev.getEpoch()) {
prev.setEpoch(realEpoch);
prev.setMaxOffset(realMaxOffset);
prev.setConfirmOffset(realConfirmOffset);
} else if (realEpoch == prev.getEpoch()) {
if (realMaxOffset > prev.getMaxOffset()) {
prev.setMaxOffset(realMaxOffset);
prev.setConfirmOffset(realConfirmOffset);
}
}
}
}
```
this code snippet logic can be optimized to be more streamlined
```java
@Override
public void onBrokerHeartbeat(String clusterName, String brokerAddr,
Integer epoch, Long maxOffset,
Long confirmOffset) {
BrokerAddrInfo addrInfo = new BrokerAddrInfo(clusterName,
brokerAddr);
BrokerLiveInfo prev = this.brokerLiveTable.get(addrInfo);
if (null == prev) {
return;
}
int realEpoch = epoch == null ? -1 : epoch;
long realMaxOffset = maxOffset == null ? -1 : maxOffset;
long realConfirmOffset = confirmOffset == null ? -1 : confirmOffset;
prev.setLastUpdateTimestamp(System.currentTimeMillis());
if (realEpoch > prev.getEpoch() || (realEpoch == prev.getEpoch() &&
realMaxOffset > prev.getMaxOffset())) {
prev.setEpoch(realEpoch);
prev.setMaxOffset(realMaxOffset);
prev.setConfirmOffset(realConfirmOffset);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
