RongtongJin commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223665575

   > Currently, the CI costs too much time, I also think changing the build 
system is a good attempt. If our members think more discussions are needed, 
let's do it. @RongtongJin
   > 
   > Also, let's follow the community guidelines, merge after some approvals is 
the best practice, if we need a merge event to trigger the GitHub action in the 
test phase, consider using a new branch. @lizhanhui
   > 
   > Unfortunately, I couldn't find the detailed guidelines about the merge 
conditions on our website, shall we discuss and clear it ASAP?
   
   Hi @zhouxinyu I agree with you that we need to reduce the time of CI and 
think it is necessary. But why did the author merge such a large PR by himself 
without any notice? In addition, he ignored some necessary tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to